Skip to content

feat: read provider-level recommendations in IntelliJ plugin (TC-4696)#259

Merged
a-oren merged 2 commits into
redhat-developer:mainfrom
a-oren:TC-4696
Jun 15, 2026
Merged

feat: read provider-level recommendations in IntelliJ plugin (TC-4696)#259
a-oren merged 2 commits into
redhat-developer:mainfrom
a-oren:TC-4696

Conversation

@a-oren

@a-oren a-oren commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Read recommendations from the new ProviderReport.recommendations map, showing each recommendation once per source with proper attribution
  • Cache recommendation data alongside vulnerability data in CAService
  • Create per-source quick-fix actions with source-attributed text
  • Maintain backward compatibility: fall back to deprecated DependencyReport.recommendation when provider-level recommendations are absent
  • Bump trustify-da-api-spec to 2.0.8 for new recommendation schema types

Jira

TC-4696 — Read provider-level recommendations in IntelliJ plugin

Test plan

  • Unit tests for thereIsRecommendation(RecommendationReport) overload
  • Unit tests for isQuickFixAvailable(RecommendationReport) overload
  • Unit tests for recommendation version extraction
  • Unit tests for backward compatibility with DependencyReport.recommendation
  • Existing Cargo and Pyproject quick-fix tests pass
  • Manual verification: open Maven/npm project in sandboxed IDE, confirm recommendations appear when backend provides provider-level data

🤖 Generated with Claude Code

@a-oren @claude
feat: read provider-level recommendations in IntelliJ plugin (TC-4696)
fe99e4b 
Update the IntelliJ plugin to read recommendations from the new
ProviderReport.recommendations map instead of DependencyReport.recommendation.
Each recommendation appears once per recommendation source with proper
attribution, eliminating per-vulnerability-source duplication. Backward
compatibility with the deprecated field is maintained.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@a-oren

a-oren commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@sourcery-ai review

@a-oren
a-oren requested a review from ruromero June 10, 2026 12:26
ruromero
ruromero requested changes Jun 15, 2026
View reviewed changes

@ruromero ruromero left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one little remark

Comment thread src/main/java/org/jboss/tools/intellij/componentanalysis/CAIntentionAction.java Outdated
}

private static @NotNull String getQuickFixTextForRecommendation(String recommendationSourceName) {
return "Quick-Fix suggestion (" + recommendationSourceName + ") - apply redhat Recommended version";

@ruromero ruromero Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return "Quick-Fix suggestion (" + recommendationSourceName + ") - apply redhat Recommended version";
return "Quick-Fix suggestion (" + recommendationSourceName + ") - apply Red Hat Recommended version";

@a-oren a-oren Jun 15, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[sdlc-workflow/verify-pr] Classified as code change request — reviewer suggests capitalizing "redhat" to "Red Hat" in quick-fix text. Already resolved in commit ad04de8. No sub-task created.

@a-oren @claude
fix: capitalize Red Hat in quick-fix suggestion text
ad04de8 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@a-oren
a-oren requested a review from ruromero June 15, 2026 08:25
@sonarqubecloud

sonarqubecloud Bot commented Jun 15, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ruromero
ruromero approved these changes Jun 15, 2026
View reviewed changes

@ruromero ruromero left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruromero

ruromero commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

don't forget to run the verify-pr

@a-oren

a-oren commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator Author

Verification Report for TC-4696 (commit ad04de8)

Check Result Details
Review Feedback PASS 1 code change request from @ruromero (capitalize "Red Hat"); resolved in commit ad04de8
Root-Cause Investigation N/A No sub-tasks created
Scope Containment WARN 1 extra file: CAIntentionActionRecommendationTest.java (new test, justified)
Diff Size PASS 8 files changed, proportionate to multi-file feature
Commit Traceability WARN Commit fe99e4b references TC-4696; commit ad04de8 does not
Sensitive Patterns PASS No secrets detected
CI Status PASS All 7 CI checks pass
Acceptance Criteria PASS 6/6 criteria met
Test Quality PASS Repetitive: PASS, Documentation: PASS, Eval Quality: N/A
Test Change Classification ADDITIVE New test file + minor setup additions to existing tests
Verification Commands N/A None specified

Overall: WARN

Two informational warnings:

  • Scope Containment: New test file CAIntentionActionRecommendationTest.java is not listed in task spec but is a justified addition for testing provider-level recommendation logic.
  • Commit Traceability: The review-fix commit ad04de8 ("fix: capitalize Red Hat in quick-fix suggestion text") does not reference TC-4696 in its message.

This comment was AI-generated by sdlc-workflow/verify-pr v0.9.2.

@a-oren
a-oren merged commit 102ce59 into redhat-developer:main Jun 15, 2026
7 checks passed
@a-oren
a-oren deleted the TC-4696 branch June 15, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruromero ruromero ruromero approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@a-oren @ruromero